[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435567#comment-16435567 ]
ASF GitHub Bot commented on SYNCOPE-1301: ----------------------------------------- GitHub user IsurangaPerera opened a pull request: https://github.com/apache/syncope/pull/70 [SYNCOPE-1301] fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/IsurangaPerera/syncope SYNCOPE-1301 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/syncope/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 ---- commit 0c9d91fa51544467e86d6427d9009306f05b1cde Author: Isuranga Perera <isurangamperera@...> Date: 2018-04-12T13:41:46Z [SYNCOPE-1301] fixed ---- > Token creation is not threadsafe > -------------------------------- > > Key: SYNCOPE-1301 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1301 > Project: Syncope > Issue Type: Bug > Components: core > Affects Versions: 2.0.8 > Reporter: Isuranga Perera > Priority: Major > Fix For: 2.0.9, 2.1.0 > > > Token create method in AccessTokenDataBinderImpl[1] is not thread safe. This > could result in several problems including > * Exist 2 different access token for a particular user at a given time which > may result in an exception thrown by method call[2] since it expects a single > token a given user. > In addition to that token replace is implemented as a combination of 2 > different functionalities. Since the method is not thread safe this may cause > some unexpected behaviors (since there can be 2 tokens exist for a particular > user. same scenario as above). > [1] > [https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java#L104] > [2] > [https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java#L113] -- This message was sent by Atlassian JIRA (v7.6.3#76005)