andrea-patricelli commented on a change in pull request #319:
URL: https://github.com/apache/syncope/pull/319#discussion_r818764359



##########
File path: 
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/user/JPALinkedAccount.java
##########
@@ -157,10 +166,9 @@ public void setEncodedPassword(final String password, 
final CipherAlgorithm ciph
     }
 
     @Override
-    public void setPassword(final String password, final CipherAlgorithm 
cipherAlgoritm) {
+    public void setPassword(final String password) {
         try {
-            this.password = ENCRYPTOR.encode(password, cipherAlgoritm);
-            this.cipherAlgorithm = cipherAlgoritm;
+            this.password = ENCRYPTOR.encode(password, this.cipherAlgorithm);

Review comment:
       `Encryptor` fallbacks to `AES` as default algorithm. So do we have to 
access conf within the JPA entity?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to