github-code-scanning[bot] commented on code in PR #413:
URL: https://github.com/apache/syncope/pull/413#discussion_r1114260262
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/policy/DefaultAccessPolicyConf.java:
##########
@@ -94,14 +92,12 @@
}
@JacksonXmlElementWrapper(localName = "requiredAttrs")
- @JacksonXmlProperty(localName = "requiredAttr")
- public List<Attr> getRequiredAttrs() {
+ public Map<String, String> getRequiredAttrs() {
return requiredAttrs;
}
@JacksonXmlElementWrapper(localName = "rejectedAttrs")
- @JacksonXmlProperty(localName = "rejectedAttr")
- public List<Attr> getRejectedAttrs() {
+ public Map<String, String> getRejectedAttrs() {
Review Comment:
## Exposing internal representation
getRejectedAttrs exposes the internal representation stored in field
rejectedAttrs. The value may be modified [after this call to
getRejectedAttrs](1).
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1213)
##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/policy/DefaultAccessPolicyConf.java:
##########
@@ -94,14 +92,12 @@
}
@JacksonXmlElementWrapper(localName = "requiredAttrs")
- @JacksonXmlProperty(localName = "requiredAttr")
- public List<Attr> getRequiredAttrs() {
+ public Map<String, String> getRequiredAttrs() {
Review Comment:
## Exposing internal representation
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](1).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](2).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](3).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](4).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](5).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](6).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](7).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](8).
getRequiredAttrs exposes the internal representation stored in field
requiredAttrs. The value may be modified [after this call to
getRequiredAttrs](9).
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1214)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
