github-advanced-security[bot] commented on code in PR #713:
URL: https://github.com/apache/syncope/pull/713#discussion_r1596856197
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/macro/MacroActions.java:
##########
@@ -28,14 +29,18 @@
*/
public interface MacroActions {
- default void validate(SyncopeForm macroTaskForm) throws
ValidationException {
- // does nothing by default
+ default Optional<String> getDefaultValue(String formProperty) {
+ return Optional.empty();
}
default Map<String, String> getDropdownValues(String formProperty) {
return Map.of();
}
+ default void validate(SyncopeForm form, Map<String, Object> vars) throws
ValidationException {
Review Comment:
## Useless parameter
The parameter 'vars' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1597)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/macro/MacroActions.java:
##########
@@ -28,14 +29,18 @@
*/
public interface MacroActions {
- default void validate(SyncopeForm macroTaskForm) throws
ValidationException {
- // does nothing by default
+ default Optional<String> getDefaultValue(String formProperty) {
+ return Optional.empty();
}
default Map<String, String> getDropdownValues(String formProperty) {
return Map.of();
}
+ default void validate(SyncopeForm form, Map<String, Object> vars) throws
ValidationException {
Review Comment:
## Useless parameter
The parameter 'form' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1596)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/macro/MacroActions.java:
##########
@@ -28,14 +29,18 @@
*/
public interface MacroActions {
- default void validate(SyncopeForm macroTaskForm) throws
ValidationException {
- // does nothing by default
+ default Optional<String> getDefaultValue(String formProperty) {
Review Comment:
## Useless parameter
The parameter 'formProperty' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1599)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
