github-advanced-security[bot] commented on code in PR #916:
URL: https://github.com/apache/syncope/pull/916#discussion_r1853912267
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/ProvisioningActions.java:
##########
@@ -26,19 +26,17 @@
* Action to be executed before to start the provisioning (push / pull)
task execution.
*
* @param profile provisioning profile
- * @throws JobExecutionException in case of generic failure
*/
- default void beforeAll(ProvisioningProfile<?, ?> profile) throws
JobExecutionException {
+ default void beforeAll(ProvisioningProfile<?, ?> profile) {
Review Comment:
## Useless parameter
The parameter 'profile' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1645)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -92,12 +91,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param linkedAccount create request
- * @throws JobExecutionException in case of generic failure
*/
default void beforeProvision(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- LinkedAccountTO linkedAccount) throws JobExecutionException {
+ LinkedAccountTO linkedAccount) {
Review Comment:
## Useless parameter
The parameter 'linkedAccount' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1677)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -154,12 +149,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param realm realm
- * @throws JobExecutionException in case of generic failure
*/
default void beforeAssign(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- RealmTO realm) throws JobExecutionException {
+ RealmTO realm) {
Review Comment:
## Useless parameter
The parameter 'realm' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1666)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -138,12 +134,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param linkedAccount linked account
- * @throws JobExecutionException in case of generic failure
*/
default void beforeAssign(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- LinkedAccountTO linkedAccount) throws JobExecutionException {
+ LinkedAccountTO linkedAccount) {
Review Comment:
## Useless parameter
The parameter 'linkedAccount' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1669)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -186,12 +179,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param entity entity
- * @throws JobExecutionException in case of generic failure
*/
default void beforeDeprovision(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- EntityTO entity) throws JobExecutionException {
+ EntityTO entity) {
Review Comment:
## Useless parameter
The parameter 'entity' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1660)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -170,12 +164,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param entity entity
- * @throws JobExecutionException in case of generic failure
*/
default void beforeUnassign(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- EntityTO entity) throws JobExecutionException {
+ EntityTO entity) {
Review Comment:
## Useless parameter
The parameter 'entity' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1663)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PushActions.java:
##########
@@ -168,13 +160,12 @@
* @param entity pushed entity.
* @param result operation result.
* @param error error being reported
- * @throws JobExecutionException in case of generic failure
*/
default void onError(
ProvisioningProfile<?, ?> profile,
Entity entity,
ProvisioningReport result,
- Exception error) throws JobExecutionException {
+ Exception error) {
Review Comment:
## Useless parameter
The parameter 'error' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1685)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -218,12 +209,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param entity entity
- * @throws JobExecutionException in case of generic failure
*/
default void beforeLink(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- EntityTO entity) throws JobExecutionException {
+ EntityTO entity) {
Review Comment:
## Useless parameter
The parameter 'entity' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1654)
##########
ext/elasticsearch/client-elasticsearch/src/main/java/org/apache/syncope/ext/elasticsearch/client/ElasticsearchUtils.java:
##########
@@ -268,7 +268,6 @@
protected void customizeDocument(
final Map<String, Object> builder,
- final AuditEvent auditEvent)
- throws IOException {
+ final AuditEvent auditEvent) {
Review Comment:
## Useless parameter
The parameter 'auditEvent' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1695)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -202,12 +194,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param entity entity
- * @throws JobExecutionException in case of generic failure
*/
default void beforeUnlink(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- EntityTO entity) throws JobExecutionException {
+ EntityTO entity) {
Review Comment:
## Useless parameter
The parameter 'entity' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1657)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -250,12 +240,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param entity entity
- * @throws JobExecutionException in case of generic failure
*/
default void beforeDelete(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- EntityTO entity) throws JobExecutionException {
+ EntityTO entity) {
Review Comment:
## Useless parameter
The parameter 'entity' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1651)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -285,12 +274,11 @@
* beforeDelete)
* @param e the exception thrown
* @return an instance of the given exception type is that is to be
thrown; {@code NULL} otherwise
- * @throws JobExecutionException in case of generic failure
*/
default IgnoreProvisionException onError(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- Exception e) throws JobExecutionException {
+ Exception e) {
Review Comment:
## Useless parameter
The parameter 'e' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1648)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PushActions.java:
##########
@@ -185,12 +176,11 @@
* @param profile profile of the push being executed.
* @param entity pushed entity.
* @param result operation result.
- * @throws JobExecutionException in case of generic failure
*/
default void after(
ProvisioningProfile<?, ?> profile,
Entity entity,
- ProvisioningReport result) throws JobExecutionException {
+ ProvisioningReport result) {
Review Comment:
## Useless parameter
The parameter 'result' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1681)
##########
ext/opensearch/client-opensearch/src/main/java/org/apache/syncope/ext/opensearch/client/OpenSearchUtils.java:
##########
@@ -268,7 +268,6 @@
protected void customizeDocument(
final Map<String, Object> builder,
- final AuditEvent auditEvent)
- throws IOException {
+ final AuditEvent auditEvent) {
Review Comment:
## Useless parameter
The parameter 'auditEvent' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1697)
##########
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java:
##########
@@ -108,12 +106,11 @@
* @param profile profile of the pull being executed.
* @param delta retrieved pull information
* @param realm realm
- * @throws JobExecutionException in case of generic failure
*/
default void beforeProvision(
ProvisioningProfile<?, ?> profile,
SyncDelta delta,
- RealmTO realm) throws JobExecutionException {
+ RealmTO realm) {
Review Comment:
## Useless parameter
The parameter 'realm' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1674)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
