ilgrosso commented on code in PR #1119:
URL: https://github.com/apache/syncope/pull/1119#discussion_r2174454970


##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SyncopeAuthModuleConf.java:
##########
@@ -55,6 +57,10 @@ public void setCredentialCriteria(final String 
credentialCriteria) {
         this.credentialCriteria = credentialCriteria;
     }
 
+    public int getMaxRetryAttempts() { return maxRetryAttempts; }
+
+    public void setMaxRetryAttempts(int maxRetryAttempts) { 
this.maxRetryAttempts = maxRetryAttempts; }

Review Comment:
   this is not going to pass checkstyle: ensure to run the build locally before 
submitting



##########
common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SyncopeAuthModuleConf.java:
##########
@@ -39,6 +39,8 @@ public class SyncopeAuthModuleConf implements AuthModuleConf {
      */
     private String credentialCriteria;
 
+    private int maxRetryAttempts = 1;

Review Comment:
   add `@Min(1)` to this property



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to