ilgrosso commented on code in PR #1198:
URL: https://github.com/apache/syncope/pull/1198#discussion_r2389943015
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/AbstractPushResultHandler.java:
##########
@@ -179,6 +181,10 @@ protected void link(final Any<?> any, final boolean
unlink, final ProvisioningRe
operation(unlink ? PatchOperation.DELETE :
PatchOperation.ADD_REPLACE).
value(profile.getTask().getResource().getKey()).build());
+ if (any instanceof Group && ((Group) any).getUDynMembership() != null)
{
Review Comment:
You should do the same for `adynMembershipConds`
Moreover, it could make sense to centralize the changes you are introducing
in a single method like as
```java
protected void copyDynMembershipConds(final Any<?> any, final AnyUR req) {
if (any instanceof Group && ((Group) any).getUDynMembership() != null) {
((GroupUR) req).setUDynMembershipCond(((Group)
any).getUDynMembership().getFIQLCond());
// also copy aDynMembershipConds
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
