github-advanced-security[bot] commented on code in PR #1258:
URL: https://github.com/apache/syncope/pull/1258#discussion_r2603378734
##########
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/spring/DomainRoutingEntityManagerFactory.java:
##########
@@ -56,25 +63,21 @@
protected void addToJpaPropertyMap(
final DomainEntityManagerFactoryBean emf,
- final OpenJpaVendorAdapter vendorAdapter,
+ final JpaVendorAdapter vendorAdapter,
final String dbSchema,
- final String orm,
- final String metadataFactory) {
+ final String orm) {
Review Comment:
## Useless parameter
The parameter 'orm' is never used.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/2367)
##########
common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/jackson/SyncopeJsonMapper.java:
##########
@@ -62,32 +60,47 @@
}
@Override
- public void writeValue(final JsonGenerator jgen, final Object value)
throws IOException {
+ public void writeValue(final DataOutput out, final Object value) throws
JacksonException {
Review Comment:
## Confusing overloading of methods
Method SyncopeJsonMapper.writeValue(..) could be confused with overloaded
method [writeValue](1), since dispatch depends on static types.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/2377)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
