ilgrosso commented on code in PR #1580:
URL: https://github.com/apache/syncope/pull/1580#discussion_r4325604421
##########
client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java:
##########
@@ -378,10 +354,10 @@ public String getObject(
if (jexlHelp) {
AjaxTextFieldPanel.class.cast(panel).enableJexlHelp();
}
+ }
- if (required) {
- panel.addRequiredLabel();
- }
+ if (required) {
Review Comment:
> I haven't thoroughly reviewed all the WA configurations
Maybe you should; at least, switch to the new component when the backing
property is `Boolean` without `@NonNull` annotation, e.g. can actually assume
legitimate `null` value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
