If there are no size constraints then I will suggest adding Janino into the lib directory as we are using it for providing string processing functionalities in DML.

Shafaq Siddiqi

On 6/16/2021 7:56 PM, arnab phani wrote:
Today we include libraries that are needed to run in standalone mode. I
like this balance.
However, we might have missing libraries such as janino, that is needed for
standalone execution.

Regards,
Arnab..

On Wed, Jun 16, 2021, 19:50 Mark Dokter <[email protected]> wrote:

Hey there!

When testing the release candidate, Shafaq and I found jars without
which SystemDS crashes under certain conditions.

* janino*.jar is needed for map() and for codegen.
* spark-core*.jar is needed for -exec hybrid when running locally
(otherwise provided by Spark)

These problems do not occur when using the source distribution as Maven
pulls everything in that's needed.

The safe solution is to include everything that Maven pulls into the lib
directory. But taking a look at the size of this directory shows 190 MB.
So aside from any legal redistribution issues (I hope there are none?)
the release artifacts would be blown up by quite a bit.

Any thoughts?

Regards, Mark


Reply via email to