kev-inn commented on PR #1628: URL: https://github.com/apache/systemds/pull/1628#issuecomment-1153891131
I am sorry that this PR got so large. I believe it is better to do it in one go, but I can also break it down so the review is faster. I recommend to open the old `FEDInstructionUtils.java` file on one screen and on the other screen go through all added `toFedInstruction()` methods. This will allows to easily match the old conditions with the new, more compact and (hopefully) easier to read conditions. There aren't many changes to the logic, except that I changed (or added, see `AppendSPInstruction`) some super-classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
