Baunsgaard commented on code in PR #1672:
URL: https://github.com/apache/systemds/pull/1672#discussion_r953945189
##########
src/main/java/org/apache/sysds/lops/compile/Dag.java:
##########
@@ -304,9 +306,9 @@ private ArrayList<Instruction>
doPlainInstructionGen(StatementBlock sb, List<Lop
// filter out non-executable nodes
List<Lop> execNodes = nodes.stream()
- .filter(l -> (!l.isDataExecLocation()
+ .filter(l -> (!l.isDataIOGenExecLocation() &&
!l.isReaderGenExecLocation() && (!l.isDataExecLocation()
Review Comment:
make a helper method in `l` that get this boolean out, (you do this rewrite
multiple times.)
`!l.isDataIOGenExecLocation() && !l.isReaderGenExecLocation()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
