louislepage commented on PR #1946: URL: https://github.com/apache/systemds/pull/1946#issuecomment-2249456949
After finishing the thesis, I started moving the explainer was to builtin as [scripts/builtin/shapExplainer.dml](https://github.com/louislepage/systemds/blob/abf1b8ae311353f414a169f13b12b60d7cd55233/scripts/builtin/shapExplainer.dml). For the final merge, all files under [scripts/staging/shapley_values](https://github.com/louislepage/systemds/tree/shap-values/scripts/staging/shapley_values) will be removed. The experiments are available as part of the [reproducibility repository of the thesis](https://github.com/louislepage/scalable-shap-reproducibility). Unit- and component tests were added in [test/functions/builtin/part2/BuiltinShapExplainerTest.java](https://github.com/louislepage/systemds/blob/abf1b8ae311353f414a169f13b12b60d7cd55233/src/test/java/org/apache/sysds/test/functions/builtin/part2/BuiltinShapExplainerTest.java) which use tests written in DML in [test/scripts/functions/builtin/shapExplainerUnit.dml](https://github.com/louislepage/systemds/blob/abf1b8ae311353f414a169f13b12b60d7cd55233/src/test/scripts/functions/builtin/shapExplainerUnit.dml) and [test/scripts/functions/builtin/shapExplainerComponent.dml](https://github.com/louislepage/systemds/blob/abf1b8ae311353f414a169f13b12b60d7cd55233/src/test/scripts/functions/builtin/shapExplainerComponent.dml). The DML file also stores the expected results for each test, results are compared within the javatest. This may be a bit unconventional, but it reduces the amount of files/code since otherwise all expected results would have to be written in java and each unit test woul d need to go to its own DML script. I hope this is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
