thomas9t commented on issue #854: [SYSTEMML-1325] Fix GPU cleanup bug when 
invoked with JMLC.
URL: https://github.com/apache/systemml/pull/854#issuecomment-469509770
 
 
   @niketanpansare - this looks good to me and I confirm resolves the 
performance issues we noted earlier. I had originally thought we should extend 
this to objects allocated on the CPU as well. However, `rmvar` already removes 
references to these objects from the symbol table, so I think they can be 
garbage collected by the JVM under memory pressure. Do you agree?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to