Baunsgaard commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r403498782
########## File path: src/main/python/systemds/utils/consts.py ########## @@ -0,0 +1,23 @@ +# ------------------------------------------------------------------------------ +# Copyright 2020 Graz University of Technology +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# ------------------------------------------------------------------------------ +from typing import Union + +MODULE_NAME = 'systemds' +VALID_INPUT_TYPES = Union['DAGNode', str, int, float, bool] +BINARY_OPERATIONS = ['+', '-', '/', '//', '*', '<', '<=', '>', '>=', '==', '!='] +# TODO add numpy array and implement for numpy array +VALID_ARITHMETIC_TYPES = Union['DAGNode', int, float] Review comment: Nice, i like this in one independent file! :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
