phaniarnab commented on a change in pull request #876: [SYSTEMDS-331] Cache and
Reuse scalar results
URL: https://github.com/apache/systemml/pull/876#discussion_r403723111
##########
File path:
src/main/java/org/apache/sysds/runtime/instructions/cp/StringObject.java
##########
@@ -59,6 +59,11 @@ public String getStringValue(){
public Object getValue(){
return _value;
}
+
+ @Override
+ public int getSize() {
+ return 36 + _value.length() * 2; //FIXME
Review comment:
Yeah, JOL is good. I thought of using java.lang.instrument.Instrumentation
though, in a future commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
