kev-inn commented on a change in pull request #874: Add SystemDSContext for systemds operations URL: https://github.com/apache/systemml/pull/874#discussion_r406406144
########## File path: src/main/python/docs/source/matrix.rst ########## @@ -49,13 +66,18 @@ Matrix ------ A ``Matrix`` is represented either by an ``OperationNode``, or the derived class ``Matrix``. -An Matrix can recognized it by checking the ``output_type`` of the object. +An Matrix can be recognized it by checking the ``output_type`` of the object. Matrices are the most fundamental objects we operate on. -If one generate the matrix in SystemDS directly via a function call, -it can be used in an function which will generate an ``OperationNode`` e.g. ``federated``, ``full``, ``seq``. -If we want to work on an numpy array we need to use the class ``Matrix``. +Although we can generate matrices with the function calls or object construction specified below, +the recommended way is to use the methods defined on ``SystemDSContext``. + +If we can generate the matrix in SystemDS directly via a function call, +an python function exists which will generate an ``OperationNode`` e.g. ``federated``, ``full``, ``seq``, +representing the SystemDS operation. + +If we want to work on an numpy array or want to read a matrix from a file, we need to use the class ``Matrix``. Review comment: We have examples in `simple_examples.rst`, I planned for `matrix.rst` to be a pretty basic API overview and write more detailed guides in other files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
