Baunsgaard commented on a change in pull request #892:
URL: https://github.com/apache/systemml/pull/892#discussion_r415304170
##########
File path: src/main/python/systemds/matrix/operation_node.py
##########
@@ -229,3 +233,10 @@ def moment(self, moment, weights: DAGNode = None) ->
'OperationNode':
unnamed_inputs.append(weights)
unnamed_inputs.append(moment)
return OperationNode(self.sds_context, 'moment', unnamed_inputs,
output_type=OutputType.DOUBLE)
+
+ def lm(self, y: DAGNode, **kwargs) -> 'OperationNode':
Review comment:
Something along the lines of "buildin", and if you make it then it would
be great to move l2svm along with it.
But, lest do that in another PR at some later point, because then we will
merge this PR shortly
##########
File path: src/main/python/systemds/matrix/matrix.py
##########
@@ -141,3 +141,32 @@ def seq(sds_context: 'SystemDSContext', start:
Union[float, int], stop: Union[fl
start = 0
unnamed_input_nodes = [start, stop, step]
return OperationNode(sds_context, 'seq', unnamed_input_nodes)
+
+
Review comment:
(OCD comment) double newline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
