Baunsgaard commented on pull request #910: URL: https://github.com/apache/systemml/pull/910#issuecomment-629522302
Double checked if there was a performance change between before and after. (was sure I did this before PR as well and observed a significant change of 10 sec) and to my surprise the difference i observed in the beginning, ended up non existing. (most likely because the system is actually doing the optimizations correctly) Therefore some of the changes are reverted back (not all), so all in all less impactful than I expected but, great learning experience :+1: . bellow is some of the resulting times, and the script: implementation | time (avg 10 runs) --- | --- msvm | 78.2128 msvm-before | 78.4258 l2svm | 79.042 ```R # data from http://archive.ics.uci.edu/ml/machine-learning-databases/covtype/covtype.data.gz data = read("data/covtype.data") X = data[,1:54] Y = data[,55] model = msvm(X=X, Y=Y, num_classes=max(Y), maxiterations = 300, epsilon= 1e-15) # should print 0.009315662472918557 print(toString(sum(model))) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
