Baunsgaard commented on a change in pull request #916:
URL: https://github.com/apache/systemml/pull/916#discussion_r429069619
##########
File path: src/main/java/org/apache/sysds/common/Builtins.java
##########
@@ -173,6 +173,7 @@
TAN("tan", false),
TANH("tanh", false),
TRACE("trace", false),
+ TO_ONE_HOT("to_one_hot", true),
Review comment:
After discussing this with Matthias, we think that we should try to
stick to camelCase. The same goes for the parameters. for the internal enum you
can keep it as TO_ONE_HOT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
