mboehm7 commented on pull request #932: URL: https://github.com/apache/systemml/pull/932#issuecomment-637095844
LGTM - thanks @phaniarnab. I like the idea of linking them together and only spilling if no more non-spilled references exist. Just some minor nitpicks: please also use a free line between the git message title and description - otherwise interactive rebase gets messy. Also try to keep the public/protected interfaces as narrow as possible - we need to keep the caching logic as simple as possible and having narrow entry points makes it much easier to reason about synchronization, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
