j143 commented on a change in pull request #933:
URL: https://github.com/apache/systemml/pull/933#discussion_r434360738



##########
File path: docs/builtins-reference.md
##########
@@ -143,12 +139,13 @@ kmeans(x, centers, iter.max, nstart)
 | String         |The output matrix with the centroids |
 
 
+
+**DML-bodied built-in functions** are written as DML-Scripts and executed as 
such when called.
 ### Example
 
-KMeans = rand(Matrix x, centers k=0,int iter.max=25,int nstart=10)
-return(Matrix[numerical] C,Matrix[numerical] Y)
+```h2o.kmeans(x = predictors, k = 100, estimate_k = T, standardize = F,

Review comment:
       We need to closely understand the this function:
   
https://github.com/apache/systemml/blob/faec15810e18fc497e950b830811a919f5aa5c5f/scripts/builtin/kmeans.dml#L46
   
   Think about the inputs required and initialize the required arguments.
   We can take already implemented functions as examples. 
   This task is tough and iterative, copy-paste solutions are not available. 
Some people spend whole days to find the correct combinations, though. 🙂




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to