Baunsgaard commented on a change in pull request #946: URL: https://github.com/apache/systemml/pull/946#discussion_r441449635
########## File path: src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedResponse.java ########## @@ -94,10 +94,11 @@ public void throwExceptionFromResponse() throws Exception { * If the map is empty, it means that no privacy constraints were found. * @param checkedConstraints map of checked constraints from the PrivacyMonitor */ - public void setCheckedConstraints(ConcurrentHashMap<PrivacyLevel,LongAdder> checkedConstraints){ + public void setCheckedConstraints(HashMap<PrivacyLevel,LongAdder> checkedConstraints){ if ( checkedConstraints != null && !checkedConstraints.isEmpty() ){ - this.checkedConstraints = checkedConstraints; - } + this.checkedConstraints = new HashMap<PrivacyLevel, LongAdder>(); + this.checkedConstraints.putAll(checkedConstraints); + } Review comment: EnumMap sounds good :) did not know that one, but as you say it is not necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org