Baunsgaard commented on pull request #947: URL: https://github.com/apache/systemml/pull/947#issuecomment-648652232
Hi @j143, i missed this PR and comment. I think it is fine with the dev notebook, but i don't like that so much of it is setup. Could this not be simplified? Also where do you want notebook to be? somewhere in the documentation? I don't see a link to such a thing inside the code of the PR. With regards to changing the K-means algorithm then having something else than 0 as the defaults seems reasonable, but maybe select 2? or better yet, force the user to select an value, since in the end that is something they have to do. If you look at spark they set it <http://spark.apache.org/docs/latest/ml-clustering.html> or R requires the number of clusters <https://www.rdocumentation.org/packages/stats/versions/3.6.2/topics/kmeans> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
