Not trying to say whose fault it is, but trying to see how we can catch this in the future.
I guess the open bug t(#342372) o have Eclipse git plugin to support .gitattributes will be an issue for now. [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=342372 On Tue, Jun 14, 2016 at 2:30 PM, Matthias Boehm <[email protected]> wrote: > well, this was my fault; I'm using the EGit plugin (which ignores this > file) and I've forgotten to manually double check the line separators. > > Regards, > Matthias > > [image: Inactive hide details for Luciano Resende ---06/14/2016 02:25:36 > PM---On Tue, Jun 14, 2016 at 2:14 PM, <[email protected]]Luciano > Resende ---06/14/2016 02:25:36 PM---On Tue, Jun 14, 2016 at 2:14 PM, < > [email protected]> wrote: > Repository: incubator-systemml > > From: Luciano Resende <[email protected]> > To: [email protected] > Date: 06/14/2016 02:25 PM > Subject: Re: incubator-systemml git commit: [HOTFIX] Replacing CSV file > with Windows line-endings with version that uses Unix line-endings. > ------------------------------ > > > > On Tue, Jun 14, 2016 at 2:14 PM, <[email protected]> wrote: > > > Repository: incubator-systemml > > Updated Branches: > > refs/heads/master b75823310 -> 8c37e2e1e > > > > > > [HOTFIX] Replacing CSV file with Windows line-endings with version that > > uses Unix line-endings. > > > > > > > Why this wasn't caught by the .gitattributes rules ? Should we update that > file and have something explicitly for csv ? > > > -- Luciano Resende http://twitter.com/lresende1975 http://lresende.blogspot.com/
