this is fine, but please make sure that it gets integrated into our
existing testsuite which can be run through maven or junit.
Regards,
Matthias
On 2/3/2017 9:10 PM, Deron Eriksson wrote:
+1 for enabling the Python tests in the test suite.
Since we use multiple languages and it's not always easy to catch when Java
changes break Python that depends on it, I think this would be extremely
valuable.
Deron
On Fri, Feb 3, 2017 at 11:49 AM, Niketan Pansare <npan...@us.ibm.com> wrote:
Hi all,
In our master branch, we have a unit test
org.apache.sysml.test.integration.functions.python.PythonTestRunner, that
tests our python wrappers. However, we have explicitly disabled it via a
flag RUN_PYTHON_TEST in that class. This is because the python tests have a
hard dependency on Spark installation. This is why Jenkins DOES NOT test
any of our Python wrappers and new PRs could potentially break the Python
wrappers. I wanted to know if anyone has objection to enable the Python
tests by default.
Please note, we will have to download the appropriate Spark version on
Jenkins (or on any dev machine which runs the integration tests) and set
SPARK_HOME environment variable.
Thanks,
Niketan Pansare
IBM Almaden Research Center
E-mail: npansar At us.ibm.com
http://researcher.watson.ibm.com/researcher/view.php?person=us-npansar
