[
https://issues.apache.org/jira/browse/TAJO-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644295#comment-13644295
]
Hyunsik Choi commented on TAJO-47:
----------------------------------
Looks good to me. There is a trivial thing. In 121 Line of TestRowFile, there
are double semi colons.
Since Tajo has hanging problem now, I didn't try unit tests. The hanging
problem will be fixed in TAJO-44. After I commit TAJO-44, I'll try unit tests
for your patch.
> RowFile has the duplicated initialization problem and unflipped ByteBuffer
> problem
> ----------------------------------------------------------------------------------
>
> Key: TAJO-47
> URL: https://issues.apache.org/jira/browse/TAJO-47
> Project: Tajo
> Issue Type: Bug
> Components: storage
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Attachments: TAJO-47.patch
>
>
> 1) Duplicated initialization problem
> FileScanner has the init() interface which is generally called by upper
> layers. The init() call in the constructor of RowFileScanner incurs the
> duplicated initialization problem.
> 2) Unflipped ByteBuffer problem
> RowFileScanner reads data from FSDataInputStream via the ByteBuffer
> interface. ByteBuffer should be flipped after every reads, but it is not
> flipped when FSDataInputStream does not return data anymore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
