[ 
https://issues.apache.org/jira/browse/TAMAYA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507322#comment-16507322
 ] 

ASF GitHub Bot commented on TAMAYA-340:
---------------------------------------

GitHub user peculater opened a pull request:

    https://github.com/apache/incubator-tamaya/pull/21

    TAMAYA-340 Bugfix for regex "\\." vs literal "."

    String.replaceAll(String, String) takes a regex as its first argument,
    not a literal replaceable string.  The result of this is that any
    single-character environment variable is converted to use the "_" key
    which has special significance to the system.  Tests in the extensions
    repo include some that have a single character which this change should
    get working again.  I've included a test in this repo for that case as
    well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peculater/incubator-tamaya 
TAMAYA-340-regex-bugfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tamaya/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit 7352d6ae062224a0c72f7524f43a072f9464fbb6
Author: William Lieurance <william.lieurance@...>
Date:   2018-06-10T09:20:12Z

    TAMAYA-340 Bugfix for regex "\\." vs literal "."
    
    String.replaceAll(String, String) takes a regex as its first argument,
    not a literal replaceable string.  The result of this is that any
    single-character environment variable is converted to use the "_" key
    which has special significance to the system.  Tests in the extensions
    repo include some that have a single character which this change should
    get working again.  I've included a test in this repo for that case as
    well.

----


> Alternative property keys for environment variables
> ---------------------------------------------------
>
>                 Key: TAMAYA-340
>                 URL: https://issues.apache.org/jira/browse/TAMAYA-340
>             Project: Tamaya
>          Issue Type: New Feature
>            Reporter: Harald Wellmann
>            Assignee: Anatole Tresch
>            Priority: Major
>             Fix For: 0.4-incubating
>
>
> h3. Background
> Some operating systems (e.g. Windows) do not support dots in environment 
> variable names.
> h3. Goals
> When looking up a config value for key {{foo.bar.blah}}, Tamaya should also 
> try the fallback key {{FOO_BAR_BLAH}}.
> This is also part of the [Config JSR 
> requirements|https://github.com/eclipse/ConfigJSR/blob/25edda2914155ac6b30f821f9ef13e92b7350a3a/spec/src/main/asciidoc/configsources.asciidoc],



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to