[ 
https://issues.apache.org/jira/browse/TAMAYA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626208#comment-16626208
 ] 

ASF GitHub Bot commented on TAMAYA-351:
---------------------------------------

Github user ottlinger commented on a diff in the pull request:

    
https://github.com/apache/incubator-tamaya-extensions/pull/9#discussion_r219938377
  
    --- Diff: 
modules/resolver/src/main/java/org/apache/tamaya/resolver/internal/FileResolver.java
 ---
    @@ -86,7 +86,12 @@ public String evaluate(String expression) {
                     builder.append(inputLine).append("\n");
                 }
     
    -            return builder.toString();
    +            String content = builder.toString();
    +            if (content.endsWith("\n")) {
    +                content = content.substring(0, conent.length() - 2);       
 
    --- End diff --
    
    conent? Seems like a typo to me.
    
    Is it possible to provide/augment a test case to verify the behaviour and 
prevent regressions in the future. Thanks.


> Do not append newline (\n) at the end of a value when resolved with 
> FileResolver
> --------------------------------------------------------------------------------
>
>                 Key: TAMAYA-351
>                 URL: https://issues.apache.org/jira/browse/TAMAYA-351
>             Project: Tamaya
>          Issue Type: Bug
>            Reporter: Alexander Suter
>            Priority: Major
>
> FileResolver always adds a new line (\n) at the end of the value. This leads 
> to the issue that the value will be postfixed with a new line, when I load an 
> value which has been resolved with the FileResolver,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to