I don't think Checkstyle is able to identify unused variables. Findbugs *should* be able to do this, though when I tried running the analysis via `mvn clean verify site`, the report didn't include the unused LOG variable in the SupplierConverter class mentioned earlier. In fact, nothing was reported from tamaya-core, though it may be that I was running the analysis incorrectly. AFAIK, the test code isn't analyzed at all by findbugs.
It is also my impression that findbugs is no longer maintained. Perhaps it would be worthwhile changing over to spotbugs or PMD? Alternatively, once the Sonar integration is set up, that should be able to generate reports identifying all the unused variables. Aaron On Mon, Mar 25, 2019 at 4:39 PM P. Ottlinger <pottlin...@apache.org> wrote: > Hi, > > Am 22.03.19 um 05:08 schrieb Aaron Coburn: > > Which modules don't have checkstyle enabled? > > Not sure if it's configured but > tamaya-core > has some unused variables, that I'd expect to be marked by Checkstyle. > > Is that the case? > > e.g. > > /tamaya-core/src/main/java/org/apache/tamaya/core/internal/converters/SupplierConverter.java > > Tests have multiple unused variables - is that a rule? > > Thanks, > Phil > >
