Fully agree. Log4j should be in provided scope, or removed if it's not needed in the core at all. Adding it directly to the archetype pom makes sense.
Kalle On Tue, Jan 18, 2011 at 10:19 AM, Robert Zeigler <[email protected]> wrote: > Not a compile dependency, that I'm aware of. How many users start with the > quickstart as a basis for new projects? If that's a large percentage, > couldn't we move the log4j dependency declaration into the generated pom? > Then it's even easier to change for people who want to change it, and removes > the fishy dependency in tapestry-core. Making that change now would need a > definite note in upgrade notes so that log4j users who were relying on the > tapestry-supplied dependency would know to tweak their pom to add their own > dep. > > Robert > > On Jan 18, 2011, at 1/1812:15 PM , Josh Canfield wrote: > >> :) I'm also moving to gradle so it's a different kind of magic. >> >> compile("org.apache.tapestry:tapestry-core:$tapestryVersion") { >> exclude module: 'slf4j-log4j12' >> exclude module: 'log4j' >> } >> >> Making it a compile dependency saves end users from needing to include log4j >> in their poms (or other dependency managers), but it feels... smelly? There >> isn't actually a compile dependency, right? >> >> Josh >> >> On Tue, Jan 18, 2011 at 8:54 AM, Howard Lewis Ship <[email protected]> wrote: >> >>> Yes, but the vast majority will use Log4J, and those enlightened >>> enough to prefer Logback will also be enlightened enough to know the >>> Maven pom incantation to include logback and exclude log4j. >>> >>> On Tue, Jan 18, 2011 at 7:52 AM, Josh Canfield <[email protected]> >>> wrote: >>>> Agreed. I'm moving to logback and have to exclude log4j. >>>> On Jan 18, 2011 7:32 AM, "Massimo Lusetti" <[email protected]> wrote: >>>>> Why there's a log4j dep? ... Maybe I'm in the 0.00001% of applications >>>>> (who) will need to override this dependency to not use Log4J but why >>>>> using slf4j then "force" a log implementation? >>>>> >>>>> Cheers >>>>> -- >>>>> Massimo >>>>> http://meridio.blogspot.com >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>> >>> >>> >>> >>> -- >>> Howard M. Lewis Ship >>> >>> Creator of Apache Tapestry >>> >>> The source for Tapestry training, mentoring and support. Contact me to >>> learn how I can get you up and productive in Tapestry fast! >>> >>> (971) 678-5210 >>> http://howardlewisship.com >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
