Re: svn commit: r1134868 - in /tapestry/tapestry5/trunk: ./ plastic/ tapestry-annotations/ tapestry-beanvalidator/ tapestry-core/ tapestry-func/ tapestry-hibernate-core/ tapestry-hibernate/ tapestry-ioc/ tapestry-javadoc/ tapestry-jmx/ tapestry-jpa/

Sun, 12 Jun 2011 12:55:38 -0700 

It would create a circular dependency.

Отправлено с iPhone
12.06.2011, в 21:19, Christian Riedel <[email protected]> написал(а):
Don't create more modules! It would be sufficient to put IOCTestCase into tapestry-test, I think... :-) 


Am 12.06.2011 um 20:57 schrieb Igor Drobiazko:


You are right but same applies for org.testng:testng.
However, Gradle's "idea" plugin skips provided dependencies and it results in compilation errors in IOCTestCase. This class is located in src/ main/java but depends on tapestry-test which has the provided scope. IOCTestCase is a test dependency but is included into the tapestry-ioc.jar. The reason for 
that is that various tests in tapestry-core extend IOCTestCase.
I think our build should create an additional jar for tapestry-ioc with "test" qualifier. Having IOCTestCase on the runtime classpath feels wrong.
On Sun, Jun 12, 2011 at 2:07 PM, Howard Lewis Ship <[email protected]> wrote: 


Are you sure this is correct?  It seems to me that it will make
tapestry-test a transient dependency of tapestry-core. Having it be a 
provided dependency should not make it a transient dependency, and I
believe that's what we want.


On Sat, Jun 11, 2011 at 11:18 PM,  <[email protected]> wrote:

Author: drobiazko
Date: Sun Jun 12 06:18:13 2011
New Revision: 1134868

URL: http://svn.apache.org/viewvc?rev=1134868&view=rev
Log:
Changed tapestry-ioc's dependency on tapestry-test to compile scope

Modified:
 tapestry/tapestry5/trunk/   (props changed)
 tapestry/tapestry5/trunk/plastic/   (props changed)
 tapestry/tapestry5/trunk/tapestry-annotations/   (props changed)
 tapestry/tapestry5/trunk/tapestry-beanvalidator/   (props changed)
 tapestry/tapestry5/trunk/tapestry-core/   (props changed)
 tapestry/tapestry5/trunk/tapestry-func/   (props changed)
 tapestry/tapestry5/trunk/tapestry-hibernate/   (props changed)
tapestry/tapestry5/trunk/tapestry-hibernate-core/ (props changed) 
 tapestry/tapestry5/trunk/tapestry-ioc/   (props changed)
 tapestry/tapestry5/trunk/tapestry-ioc/build.gradle
 tapestry/tapestry5/trunk/tapestry-javadoc/   (props changed)
 tapestry/tapestry5/trunk/tapestry-jmx/   (props changed)
 tapestry/tapestry5/trunk/tapestry-jpa/   (props changed)
 tapestry/tapestry5/trunk/tapestry-json/   (props changed)
 tapestry/tapestry5/trunk/tapestry-spring/   (props changed)
 tapestry/tapestry5/trunk/tapestry-test/   (props changed)
 tapestry/tapestry5/trunk/tapestry-upload/   (props changed)
 tapestry/tapestry5/trunk/tapestry-yuicompressor/   (props changed)

Propchange: tapestry/tapestry5/trunk/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -15,5 +15,5 @@ temp-testng-customsuite.xml
test-output

*.idea
-
+out
build

Propchange: tapestry/tapestry5/trunk/plastic/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -5,3 +5,4 @@
bin
build
target
+out

Propchange: tapestry/tapestry5/trunk/tapestry-annotations/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -2,7 +2,6 @@ target
.classpath
.project
.settings
-
build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-beanvalidator/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -3,7 +3,6 @@ test-output
.project
.settings
target
-
build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-core/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -12,7 +12,6 @@ target
temp-testng-customsuite.xml
test-output
testng.xml
-
build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-func/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -3,9 +3,7 @@
target

.project
-
.classpath
-
build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-hibernate/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -9,5 +9,5 @@ test-output
.settings

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-hibernate-core/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -4,5 +4,5 @@
target

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-ioc/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -11,5 +11,5 @@ temp-testng-customsuite.xml
test-output

build
-
+out
*.iml

Modified: tapestry/tapestry5/trunk/tapestry-ioc/build.gradle
URL:

http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/build.gradle?rev=1134868&r1=1134867&r2=1134868&view=diff
=== === === === ================================================================== 
--- tapestry/tapestry5/trunk/tapestry-ioc/build.gradle (original)
+++ tapestry/tapestry5/trunk/tapestry-ioc/build.gradle Sun Jun 12

06:18:13 2011

@@ -6,7 +6,7 @@ dependencies {
compile project(':tapestry-json')
compile project(":plastic")

-  provided project(':tapestry-test')
+  compile project(':tapestry-test')

compile "javassist:javassist:3.12.1.GA"


Propchange: tapestry/tapestry5/trunk/tapestry-javadoc/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (added)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -0,0 +1,4 @@
+*.iml
+out
+target
+build

Propchange: tapestry/tapestry5/trunk/tapestry-jmx/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -4,5 +4,5 @@ target
.classpath

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-jpa/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -9,5 +9,5 @@ test-output
.project

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-json/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -7,5 +7,5 @@ target
.project

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-spring/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -11,5 +11,5 @@ bin-test
test-output

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-test/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -5,5 +5,5 @@ target
.settings

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-upload/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -8,5 +8,5 @@ temp-testng-customsuite.xml
.settings

build
-
+out
*.iml

Propchange: tapestry/tapestry5/trunk/tapestry-yuicompressor/
--- --- --- --- ------------------------------------------------------------------ 
--- svn:ignore (original)
+++ svn:ignore Sun Jun 12 06:18:13 2011
@@ -1,3 +1,3 @@
build
-
+out
*.iml







--
Howard M. Lewis Ship

Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to 
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com
--- ------------------------------------------------------------------ 
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]





--
Best regards,

Igor Drobiazko
http://tapestry5.de



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to