I added the deprecated in 5.3.1 comment, but the LinkCreationListener was actually deprecated in 5.2.0. If we consider that it's only parameter has been deprecated for a whole release then third parties should have moved off of it by now. Right? Or do we want to deprecate the interface methods for a release?
On Mon, Jun 27, 2011 at 10:31 PM, Howard Lewis Ship <[email protected]> wrote: > It's a public API that may be used in some third party libraries. It needs > at least one release before h removal. > On Jun 27, 2011 8:55 PM, "Josh Canfield" <[email protected]> wrote: >> Any reason not to delete the methods? >> >> There is no internal code using them, and remove currently throws an >> exception in the only internal implementation. >> >> >> public interface LinkCreationHub >> { >> /** >> * Adds a listener. If the scope of the listener is per-thread, >> then it must be removed. >> * >> * @param listener >> * @deprecated since 5.3.1 >> */ >> void addListener(LinkCreationListener listener); >> >> /** >> * Removes a previously added listener. >> * >> * @param listener >> * @deprecated since 5.3.1 >> */ >> void removeListener(LinkCreationListener listener); >> >> /** >> * Adds a listener. If the scope of the listener is per-thread, >> then it must be removed. >> * >> * @param listener >> * @since 5.2.0 >> */ >> void addListener(LinkCreationListener2 listener); >> } >> >> Josh >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
