Apparently, I didn't understand snapshot deployment, I was only thinking in terms of manual execution of generateRelease; I'll figure out how to split doSign and canDeploy again.
On Mon, Jan 30, 2012 at 10:23 AM, Ulrich Stärk <u...@spielviel.de> wrote: > On 30.01.2012 17:01, hls...@apache.org wrote: >> Author: hlship >> Date: Mon Jan 30 16:01:47 2012 >> New Revision: 1237745 >> >> URL: http://svn.apache.org/viewvc?rev=1237745&view=rev >> Log: >> Update the build to generate and upload PGP signatures along with the MD5 >> checksums for the sources and javadoc artifacts >> >> Modified: >> tapestry/tapestry5/trunk/build.gradle >> >> Modified: tapestry/tapestry5/trunk/build.gradle >> URL: >> http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/build.gradle?rev=1237745&r1=1237744&r2=1237745&view=diff >> ============================================================================== >> --- tapestry/tapestry5/trunk/build.gradle (original) >> +++ tapestry/tapestry5/trunk/build.gradle Mon Jan 30 16:01:47 2012 >> @@ -2,6 +2,7 @@ description = "Apache Tapestry 5 Project >> >> apply plugin: "base" >> apply plugin: "sonar" >> + >> apply from: "ssh.gradle" >> apply from: "md5.gradle" >> >> @@ -35,7 +36,8 @@ doSign = !project.hasProperty("noSign") >> deployUsernameProperty = isSnapshot() ? "snapshotDeployUserName" : >> "apacheDeployUserName" >> deployPasswordProperty = isSnapshot() ? "snapshotDeployPassword" : >> "apacheDeployPassword" >> >> -canDeploy = [deployUsernameProperty, deployPasswordProperty].every { >> project.hasProperty(it) } >> +canDeploy = doSign && [deployUsernameProperty, >> deployPasswordProperty].every { project.hasProperty(it) } >> + > This breaks snapshot deployment since snapshots don't get signed but snapshot > deployment breaks if > canDeploy == false. > > Please fix, I don't know what you had in mind when you changed canDeploy to > also taking doSign into > account. > > Uli > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > -- Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to learn how I can get you up and productive in Tapestry fast! (971) 678-5210 http://howardlewisship.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
