What ever is chosen it would be nice for someone to upgrade to a newer
version of bootstrap without many changes.

Regarding the switch from 5.3 to 5.4 yes that should have some difficulties
especially if your application was overriding some tapestry css classes
such as t-data-grid,t-zone etc etc which you weren't supposed to do.Instead
you had to append your own class name and do modifications on that class.

>From now on though tapestry does not use class names to locate elements.It
uses data attributes instead so most probably you should not have a problem
upgrading to future versions of tapestry.

As far as future version of bootstrap I also don't see a major problem
upgrading as long as tapestry-core uses as less bootstrap java script code
as possible and appended css class are configurable.Like grid is (
ComponentParameterConstants.GRID_TABLE_CSS_CLASS ).

For example tapestry-core now uses bootstrap module in two places.One in
autocomplete mixin that uses bootstrap-typeahed and the other is the errors
component ( I don't know why the errors component imports bootstrap module )

In bootstrap 3, typeahead plugin is removed and instead you have to use
twitter-typeahead which is not bootstrap specific.

So if autocomplete mixin is changed to use twitter-typeahed and
import="bootstrap" is removed from alerts component there shouldn't be a
problem regarding java script side.

For the css part there might be a slide problem in ControlGroup mixin and
label component from a quick look since both have the class names hard
coded (control-label,control-group etc etc).If we can make those
configurable also then i don't think there should be a problem upgrading to
future bootstrap version at all.


On Sat, Jul 27, 2013 at 4:37 PM, Bob Harner <[email protected]> wrote:

> <switching this to the dev list>
>
> From http://blog.getbootstrap.com/ about Bootstrap 3: "With over ~1,600
> commits, ~72,000 additions/deletions, and ~300 files changed,everything has
> changed." The list of changes: https://github.com/twbs/bootstrap/pull/6342
>
> The Bootstrap version question raises a larger issue... should each version
> of Tapestry be tied to a certain version of Bootstrap?
>
> In my experience the biggest part of migrating an app from Tapestry 5.3 to
> 5.4 is adjusting to the massively changed styles of the built-in Tapestry
> components due to the introduction of Bootstrap. Even for apps that already
> use Bootstrap, there are CSS adjustments for the particular version of
> Bootstrap that Tapestry includes.
>
> I wonder if there is some mechanism that could be introduced that would
> allow for the creation of compatibility modes (or compatibility modules)
> for the CSS in the built-in components. I have no idea what that mechanism
> would look like, but if it existed then it could allow users to choose
> between Bootstrap 2 versus 3 versus the old non-Bootstrap styles.
>
> On Sat, Jul 27, 2013 at 8:49 AM, Barry Books <[email protected]> wrote:
>
> > I would agree with that.  I suspect Bootstrap 3 will be done before
> > Tapestry 5.5 and the markup between Bootstrap 2 and 3 changes.
> >
> >
> > On Sat, Jul 27, 2013 at 3:15 AM, Dimitris Zenios
> > <[email protected]>wrote:
> >
> > > Hi everyone
> > >
> > > Bootstrap 3 RC1 is released and get bootstrap page redirect to download
> > the
> > > new version instead of the old (2.3.2)
> > >
> > >
> > > As a suggestion maybe it will be better to upgrade the bundled
> bootstrap
> > > inside tapestry 5.4 to version 3 before a final release
> > >
> > > Regards
> > > Dimitris Zenios
> > >
> >
>

Reply via email to