Hello, Jochen! dom.getEventUrl fixed (again, a Coffee issue, a missing return statement makes the function return something else) and test added (I had already written it, but somehow it didn't make it to Git). Build failed and I'll take a look tomorrow. The test I've added passes locally but it's failing in Travis. I'll rewrite it a little bit.
On Wed, Apr 5, 2017 at 8:39 AM, Jochen Kemnade <jochen.kemn...@eddyson.de> wrote: > Now, dom.getEventUrl is broken on both branches. > Thiago, can you please add tests? > > ----- On Apr 4, 2017, at 6:49 PM, Thiago H. de Paula Figueiredo > thiag...@gmail.com wrote: > > > On Tue, Apr 4, 2017 at 9:37 AM, Jochen Kemnade < > jochen.kemn...@eddyson.de> > > wrote: > > > >> Thiago, > >> > > > > Hello, Jochen! > > > > > >> the JavaDoc for PublishEvent is broken, please fix it. > >> https://travis-ci.org/apache/tapestry-5/builds/218065676#L570 > >> https://travis-ci.org/apache/tapestry-5/jobs/217885298#L897 > > > > > > Thanks for noticing it. I've just fixed it in both master and 5.4.2. > > > > Are the Travis builds configured to send e-mails to any Tapestry mailing > > list? I didn't get any e-mails from them. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago
