Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70509355
--- Diff:
taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceDesc.java
---
@@ -16,79 +16,67 @@
*******************************************************************************/
package org.apache.taverna.cwl.ui.serviceprovider;
-import java.util.Arrays;
import java.util.List;
-import java.util.Map;
import javax.swing.Icon;
-import org.apache.taverna.cwl.CwlActivityConfigurationBean;
import org.apache.taverna.cwl.CwlDumyActivity;
+import com.fasterxml.jackson.databind.JsonNode;
+
import net.sf.taverna.t2.servicedescriptions.ServiceDescription;
import net.sf.taverna.t2.workflowmodel.processor.activity.Activity;
-public class CwlServiceDesc extends
ServiceDescription<CwlActivityConfigurationBean> {
+public class CwlServiceDesc extends ServiceDescription<JsonNode > {
--- End diff --
+1 for the move to `JsonNode` - except in Taverna 3 you should not need the
`<JsonNode>` generics - rather the configuration is always an
[`Configuration`](https://taverna.incubator.apache.org/javadoc/taverna-language/org/apache/taverna/scufl2/api/configurations/Configuration.html)
object which has `getJson*()` methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
