Hi Alan, Hi Stian, If the code needs any improvements/changes, please let me know. And given the code is fine, can you please advice me on my next steps ?
On Sun, Jul 24, 2016 at 5:17 AM, Nadeesh Dilanga <[email protected]> wrote: > Hi, > I sent another pull request which has completed the full support for every > docker configuration for java. Earlier we only had very basic and required > four-five like parameters. Now supports everything. You just need to > configure it in your create-container-json as key/values. > > > > On Mon, Jul 18, 2016 at 10:54 PM, Nadeesh Dilanga <[email protected]> > wrote: > >> Hi Stian, Hi Alan, >> I have sent another pull request which has aforesaid implementations. And >> this also includes some bug fixes(actually improvements) where if we try to >> start an already started container, it gives you a valid error response >> JSON from the activity plugin. Same with stoping non-started container etc. >> >> This gives smooth mvn clean install with tests. Please let me know if you >> able to run this with the tests with this update. >> >> What you need to do basically is: >> 1. Install a plain Docker Remote. >> 2. Go through the README in the docker activity plugin module and change >> the necessary files/attributes. >> 3. Then mvn clean install. >> >> (NOTE: the test uses a default python application) >> >> >> On Sun, Jul 17, 2016 at 4:20 PM, Nadeesh Dilanga <[email protected]> >> wrote: >> >>> Hi, >>> I am working on following and completed implementation of it, and need >>> slight more time to test it with real docker containers to make it false >>> proof. >>> >>> 1. Stop container support. >>> 2. Delete container support. >>> 3. Start/Stop/Delete based on container name, NOT with the container id. >>> >>> NOTE:Specifically added #3, because right now start/stop/delete >>> container happening based on container id. But container id is not a human >>> readable name. Even for unit testing it is difficult to automate it, >>> because of that. Hence provided that support. >>> >>> I will be sending a pull request for that soon. This pull request will >>> cover all fundamental and required docker capability for this activity >>> plugin. Will start another thread to discuss nexts steps. >>> >> >> >
