## Description The current error handling is a bit confused. I suggest to use the following implementation conventions. Let's use the authentication service as an example:
- `AuthenticationServiceError`: errors that will be propagated to the end users ## Type of change (select or add applied and delete the others) Error handling refactoring. ## How has this been tested? ## Checklist - [x] Fork the repo and create your branch from `master`. - [x] If you've added code that should be tested, add tests. - [x] If you've changed APIs, update the documentation. - [x] Ensure the tests pass (see CI results). - [x] Make sure your code lints/format. You can view, comment on, or merge this pull request online at: https://github.com/apache/incubator-teaclave/pull/618 -- Commit Summary -- * Polish authentication error -- File Changes -- M services/authentication/enclave/src/api_service.rs (108) M services/authentication/enclave/src/error.rs (52) M services/authentication/enclave/src/internal_service.rs (15) -- Patch Links -- https://github.com/apache/incubator-teaclave/pull/618.patch https://github.com/apache/incubator-teaclave/pull/618.diff -- Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave/pull/618 You are receiving this because you are subscribed to this thread. Message ID: <apache/incubator-teaclave/pull/[email protected]>
