DemesneGH commented on code in PR #79:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/79#discussion_r881262698
##########
README.md:
##########
@@ -74,6 +74,12 @@ $ source environment
#### 4. Build Rust applications
+Before building built-in rust examples, you need to build OP-TEE libraries
using:
Review Comment:
-> Before building Rust examples
I don't think they are "built-in" examples. We can call the Rust examples
built into the OP-TEE filesystem as "built-in" examples, but in this case they
are built separately and copied into the filesystem.
##########
README.md:
##########
@@ -151,9 +157,13 @@ $ sudo apt-get install android-tools-adb
android-tools-fastboot autoconf \
mtools netcat python-crypto python3-crypto python-pyelftools \
python3-pycryptodome python3-pyelftools python-serial python3-serial \
rsync unzip uuid-dev xdg-utils xterm xz-utils zlib1g-dev
+```
+After installing dependencies or building the Docker container, fetch the
source code from the official GitHub repository:
Review Comment:
Please wrap the long lines at 80 characters.
Reference: https://vim.fandom.com/wiki/Format_only_long_lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
