jforissier commented on PR #114: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1874024214
> > This might help: [OP-TEE/optee_os@788069f](https://github.com/OP-TEE/optee_os/commit/788069fa88ed8bf376a07991196fbf80c36b7e06) (although minimizing the cloned data is certainly a good idea regardless). > > With [OP-TEE/manifest#260](https://github.com/OP-TEE/manifest/pull/260), the rust build would be significantly lighter for OP-TEE CI. Given that I am also thinking that we should probably get rid of `OPTEE_RUST_ENABLE` flag and enable OP-TEE rust examples in the default build, thoughts? Perhaps just make it `?= y` by default, but it is always good to have a way to disable things in case they break. This also raises the question of `make check` (C apps) vs `make check-rust`. Should `make check` run both? (it makes sense if `make` builds both). But then we may want to be able to run only the C apps perhaps (`make check-c`?). TBD. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
