DemesneGH commented on PR #167: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/167#issuecomment-2655335948
@ivila > I suggest that in the future, we change some of the version strings to `edition.workspace = true` to save developers from having to update them one by one repeatedly. We have a discussion about versioning in: https://github.com/apache/incubator-teaclave-trustzone-sdk/issues/165#issuecomment-2646859519. Could you help to review that proposal? Using workspace really reduce the effort when bump version, can we have a more detailed plan on that discussion thread? Different with other Rust crates, we have more complex building environment, and `std`, `no-std`. Should all crates be in one workspace, or we manage examples in one workspace? I think more details should be clarified. > PS: maybe we should add `publish = false` in the examples too? See [[The publish field](https://doc.rust-lang.org/cargo/reference/manifest.html#the-publish-field)] for reference. When we publish crates on `crates.io`, the examples are not included in the package—only the crate's code is. While setting `publish = false` can serve as a clearer note, it doesn’t have any actual effect. We can add it in the PR of using workspace further. ----- As for this PR, we'd like not to block the release process, so the idea of workspace can be discussed and may be included in the next release. Please help to review the current version bump and give the `Reviewed-by` tag if you're okay with it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
