ivila commented on PR #171:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/171#issuecomment-2689897262
> > Why don't we make it `no-std`, I think it can be easily achieved by:
> >
> > 1. `std::collections::{HashMap, HashSet}` => `hashbrown::{HashSet,
HashMap}`
> > 2. `std::sync::RwLock` => `spin::RwLock`
> > 3. For other imports, just import from `core` or `alloc` directly.
>
> I did a quick test, and the HashMap and RwLock can be replaced with
hashbrown and spin. However, `bincode` and `anyhow` with no-std need some code
change:
>
> * bincode with no-std has not a stable release, I've tried the
https://github.com/bincode-org/bincode/releases/tag/v2.0.0-rc.3 but the API has
changed a lot.
> * Handle error using the no-std anyhow differs (reference:
https://docs.rs/anyhow/latest/anyhow/#no-std-support).
>
> I suggest we review and merge the std version first, and then update to
the no-std version in a separate PR. This way we can highlight the differences
between the two and leave a record for the std version.
I didn't look into `bincode` and `anyhow` in detail—my mistake. In that
case, I agree with your opinion; let's start with a std-only version first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
