ivila commented on code in PR #172:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/172#discussion_r1982600785
##########
setup.sh:
##########
@@ -35,12 +35,8 @@ else
source "$HOME/.cargo/env"
fi
-# Ensure the toolchain, components, and targets we've specified in
-# rust-toolchain.toml are ready to go. Since that file sets rustup's default
-# toolchain for the entire directory, all we need to do is run any
-# rustup-wrapped command to trigger installation. We've arbitrarily chosen
-# "cargo --version" since it has no other effect.
-cargo --version >/dev/null
+# install the Rust toolchain set in rust-toolchain.toml
+rustup toolchain install
Review Comment:
I think we should notice that this command requires higher version of
`rustup`.
With `rustup 1.27.1 (54dd3d00f 2024-04-24)`:
With `rustup 1.28.0 (6e19fbec7 2025-03-02)`
According to
[this](https://rust-lang.github.io/rustup/basics.html#keeping-rustup-up-to-date),
developers can use `rustup self update` to update the version of `rustup`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
