m4sterchain commented on code in PR #177: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/177#discussion_r2024085213
########## optee-utee/src/ta_session.rs: ########## @@ -0,0 +1,108 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use core::ptr; +use optee_utee_sys as raw; + +use crate::{Error, Result, TeeParam, TeeParameters, Uuid}; + +/// Represents a connection between a trusted application and another trusted application (can be user TA or pseudo TA). +pub struct TaSession { + raw: raw::TEE_TASessionHandle, Review Comment: We can maintain the timeout configuration in TaSession, to simplify the invoke_command interface. We can further provide additional constructors with default timeout for a cleaner session create/invocation workflow. ########## optee-utee/src/tee_parameter.rs: ########## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::{ParamType, ParamTypes}; +use core::{marker::PhantomData, slice}; +use optee_utee_sys as raw; + +pub trait TeeParam { + fn into_raw(&mut self) -> raw::TEE_Param; + fn param_type(&self) -> ParamType; + fn from_raw(raw: raw::TEE_Param, param_type: ParamType) -> Self; +} + +pub struct TeeParameters<A, B, C, D> { + raw: [raw::TEE_Param; 4], Review Comment: I don't get the benefit of the design of `TeeParameters` here, especially compared with a basic Rust struct declaration with four fields (arg0, arg1, arg2, arg3). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
