DemesneGH commented on code in PR #179:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/179#discussion_r2046348812
##########
.github/workflows/ci.yml:
##########
@@ -211,6 +211,28 @@ jobs:
make -j3 toolchains &&
make -j`nproc` RUST_ENABLE=y COMPILE_S_USER=32 check
+ systest:
+ runs-on: ubuntu-24.04-arm
+ container: ghcr.io/ivila/teaclave-trustzone-sdk-ci-runner:ubuntu-24.04
Review Comment:
Got it. Could you help to add some comments on the CI tasks for
clarification? Such as:
```
# Cross-compile on AMD64 and run tests in QEMU
build-and-test-examples:
# Run systest of optee_teec and build systest of optee_utee on ARM64
systest:
```
It would help us avoid confusion in the future, as we might forget the
differences.
##########
optee-utee/optee-utee-sys/src/tee_api.rs:
##########
@@ -241,7 +238,7 @@ extern "C" {
pub fn TEE_TruncateObjectData(object: TEE_ObjectHandle, size: usize) ->
TEE_Result;
pub fn TEE_SeekObjectData(
object: TEE_ObjectHandle,
- offset: i32, //intmax_t
+ offset: intmax_t, //intmax_t
Review Comment:
Remove the redundant comment `//intmax_t`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
