ivila commented on issue #189:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/issues/189#issuecomment-2892645863
For **Docker Image Naming Convention**, I think we should remove the
**${ARCH}**, as in OCI:
1) images are split by platform, not just architecture.
2) we can just build a multi platform image: [MultiPlatform |
Docker](https://docs.docker.com/build/building/multi-platform/)
Maybe just:
```
teaclave-${SDK_VER}-optee-${OPTEE_VER}-${emulator}-${std|no_std}-${build|dev}
```
PS: I also change the word `platform` to `emulator` to avoid confusion,
because the first time I saw it, I thought it is the **target_platform** of
docker😂
And with the image became a multi-platform image, the build example would be:
```shell
docker buildx build \
--platform linux/amd64,linux/arm64
--build-arg SDK_VER=${SDK_VER} \
--build-arg OPTEE_VER=${OPTEE_VER} \
--build-arg PLATFORM=${PLATFORM} \
--build-arg ARCH=${ARCH} \
--build-arg STD_TYPE=${STD_TYPE} \
--target ${stage} \
-t ${TAG}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
