ivila commented on code in PR #204:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/204#discussion_r2183994813
##########
optee-utee/src/crypto_op.rs:
##########
@@ -1505,10 +1556,9 @@ impl DeriveKey {
/// match DeriveKey::allocate(AlgorithmId::DhDeriveSharedSecret,
256) {
/// Ok(operation) => {
/// operation.set_key(&key_pair_2)?;
- /// match
TransientObject::allocate(TransientObjectType::GenericSecret,
- /// 256) {
+ /// match
TransientObject::allocate(TransientObjectType::GenericSecret, 256) {
/// // Derived key is saved as an transient object
- /// Ok(derived_key) => {
+ /// Ok(mut derived_key) => {
/// let attr_public =
AttributeMemref::from_ref(AttributeId::DhPublicValue, &public_1);
/// operation.derive(&[attr_public.into()], &mut
derived_key);
Review Comment:
false alert, `derive` doesn't return any value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
