DemesneGH commented on PR #211: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/211#issuecomment-3076634898
> It’s good to keep the Docker image available, but as a quick solution, perhaps we should either `remove these specific jobs` or `only trigger them when changes are merged into main`. `only trigger them when changes are merged into main` looks good to me for now. As discussed in https://github.com/apache/incubator-teaclave-trustzone-sdk/issues/174, the test script has not been updated for a while, meaning we cannot test the new examples, limiting the value of this test job. However, the value of this CI job, is to test the if our SDK compatible with the latest OP-TEE, which could help to catch the issue early. If it doesn't block our contribution workflow, it’s better to have this check than not. Reducing the frequency of trigger this job makes sense for me. > * A stable OP-TEE release triggers a QEMU image build. > * A QEMU image change prompts the republishing of the development Docker image, pinned to a specific OP-TEE version, supporting TA development and CI testing in both standard and no-std environments. > * Teaclave SDK development and CI rely on this stable development Docker image. It’s great to have a clear and streamlined daily workflow, but keeping the OP-TEE CI job isn’t a bad thing either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
