m4sterchain commented on code in PR #8:
URL:
https://github.com/apache/incubator-teaclave-crates/pull/8#discussion_r2278253754
##########
getrandom-0.2.16/Cargo.toml:
##########
@@ -23,6 +23,9 @@ libc = { version = "0.2.154", default-features = false }
[target.'cfg(target_os = "wasi")'.dependencies]
wasi = { version = "0.11", default-features = false }
+[target.'cfg(target_os = "optee")'.dependencies]
+optee-utee = { version = "0.4.0" }
Review Comment:
Is it possible to remove this dependency?
We could follow the approach used in Fuchsia:
https://github.com/rust-random/getrandom/blob/master/src/backends/fuchsia.rs
By doing so, we can rely on a stable interface instead of having to
sync/update the optee-utee crate version, especially when making upstream PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
